[CI] Add --succinct to lit args #152335
[CI] Add --succinct to lit args #152335
Conversation
We currently log every single test that we run in premerge. This leads to gigantic logs (200k+ lines on Linux) that can be difficult to parse through. We should only indicate progress rather than explicitly logging any test that we run. For the rare cases where someone does need to see the list of tests that run, the JUnit XML emitted by lit is available in the artifacts.
boomanaiden154
changed the title
boomanaiden154
requested review from
DavidSpickett,
dschuff,
lnihlen,
snehasish,
gburgessiv,
Keenuts,
cmtice and
Endilll
boomanaiden154
changed the title
There was a problem hiding this comment.
Having a progress indicator from lit that works in CI cases is on my TODO list.
https://llvm.org/docs/CommandGuide/lit.html#cmdoption-lit-s
"Also show a progress bar, unless --no-progress-bar is specified."
In CI systems I've used, the progress bar was usually ok while the log was being watched live, but in the final file it would be a lot of:
=
==
===
====
etc.
I don't know how well it works on GitHub but will be interested to see what you come up with.
For the rare cases where someone does need to see the list of tests that run, the JUnit XML emitted by lit is available in the artifacts.
I find myself in a lot of those rare cases, and this is fine with me. If it's somehow not enough, we can always patch the script in the same PR.
It seems to end up as this: I don't remember seeing the progress indicated at all in the log while tests were running, but maybe I just missed it. |
We currently log every single test that we run in premerge. This leads to gigantic logs (200k+ lines on Linux) that can be difficult to parse through. Having an indicator of progress is nice, especially for the LLVM tests, but is not strictly necessary and not often used (I imagine). Having a progress indicator from lit that works in CI cases is on my TODO list.
For the rare cases where someone does need to see the list of tests that run, the JUnit XML emitted by lit is available in the artifacts.